Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of jorton@redhat.com designates
 209.132.183.28 as permitted sender)
Date: Tue, 15 Jul 2014 14:18:29 +0100
From: Joe Orton <jorton@redhat.com>
To: dev@httpd.apache.org
Subject: Re: svn commit: r1610674 - in /httpd/httpd/trunk: include/ap_mmn.h
 include/httpd.h modules/proxy/mod_proxy_http.c modules/proxy/proxy_util.c
 server/util.c
Message-ID: <20140715131829.GA30464@redhat.com>
Mail-Followup-To: dev@httpd.apache.org
References: <20140715122701.0365D23888D7@eris.apache.org>
 <20140715123820.GA26706@redhat.com>
 <CAKQ1sVN02gTZ5NHDkUu50jOTGk7fKKB1pSQct+8bvb61jKNnbw@mail.gmail.com>
 <AB1691BE05AE7F4992697F2A0835627AB9B07D30@VOEXM10W.internal.vodafone.com>
 <CAKQ1sVNzrfOrLTrLak8jsgpZxF1uRii=+pn6g4Kt1yG4magtjw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAKQ1sVNzrfOrLTrLak8jsgpZxF1uRii=+pn6g4Kt1yG4magtjw@mail.gmail.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Organization: Registered in England and Wales under Company Registration No.
 03798903
  Directors: Michael Cunningham (US), Michael O'Neill (Ireland),
 Matt Parson (US), Charles Peters (US)

On Tue, Jul 15, 2014 at 03:14:56PM +0200, Yann Ylavic wrote:
> On Tue, Jul 15, 2014 at 3:07 PM, Plüm, Rüdiger, Vodafone Group
> <ruediger.pluem@vodafone.com> wrote:
> > Isn't
> >
> >  x.is_req = (headers == r->headers_in);
> >
> > in ap_proxy_clear_connection an issue, when only called with the copy of r->headers_in?
> 
> Hm, you are right.
> 
> Here is a v2 which introduces ap_proxy_clear_connection_ex(), with
>    ap_proxy_clear_connection(..., headers) <=>
> ap_proxy_clear_connection_ex(..., headers, headers == r->headers_in)

OK, great.  That works for me with both test cases I have triggering a 
400 now.

Votes for 2.4.x on that please!

+1 from me.

Regards, Joe