httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Plüm, Rüdiger, Vodafone Group <ruediger.pl...@vodafone.com>
Subject RE: Question on ap_method_* functions
Date Tue, 15 Jul 2014 08:15:54 GMT


> -----Original Message-----
> From: Christophe JAILLET [mailto:christophe.jaillet@wanadoo.fr]
> Sent: Montag, 14. Juli 2014 22:55
> To: dev@httpd.apache.org
> Subject: Question on ap_method_* functions
> 
> Hi,
> 
> I was about to submit a patch in order to remove the 'register' keyword
> in a variable declaration in 'modules/http/http_protocol.c'.
> See 'ap_method_list_remove()'
> 
> I also wanted to simplify code in the surrounding ap_method_* functions.
> 
> 
> However, I think that:
>      - in 'ap_method_list_add()',
>            l->method_mask |= (AP_METHOD_BIT << methnum);
>        should be in the
>            if (methnum != M_INVALID) { ... }
>       block
> 
>      - in 'ap_method_list_remove()',
>            l->method_mask |= ~(AP_METHOD_BIT << methnum);


Doesn't this need to be 

l->method_mask &= ~(AP_METHOD_BIT << methnum);

in order to remove it? Otherwise I set all methods but methnum.

>        should be in the
>            if (methnum != M_INVALID) { ... }
>       block
> 
> 
> Do you agree ?

Yes.

Regards

Rüdiger


Mime
View raw message