httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Christophe JAILLET <christophe.jail...@wanadoo.fr>
Subject Re: Question on ap_method_* functions
Date Tue, 15 Jul 2014 20:10:24 GMT
Le 15/07/2014 10:15, Plüm, Rüdiger, Vodafone Group a écrit :
>
>>       - in 'ap_method_list_remove()',
>>             l->method_mask |= ~(AP_METHOD_BIT << methnum);
> Doesn't this need to be
>
> l->method_mask &= ~(AP_METHOD_BIT << methnum);
>
> in order to remove it? Otherwise I set all methods but methnum.
>
>>         should be in the
>>             if (methnum != M_INVALID) { ... }
>>        block
>>
>> Do you agree ?
> Yes.
>
> Regards
>
> Rüdiger

Thanks for your comment.
Applied to trunk in r1610813 with your comment.
Proposed for 2.4.x.

Best regards,
CJ

Mime
View raw message