Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (nike.apache.org: domain of covener@gmail.com designates
 209.85.128.174 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <20140625122404.72B51238897A@eris.apache.org>
References: <20140625122404.72B51238897A@eris.apache.org>
Date: Wed, 25 Jun 2014 08:33:09 -0400
Message-ID: 
 <CALK=YjN9HfThP_k_rF9iJPcUhcQk9sNOaDPxZNG+HcJNWS4ZAQ@mail.gmail.com>
Subject: Re: svn commit: r1605369 -
 /httpd/httpd/trunk/modules/proxy/mod_proxy_wstunnel.c
From: Eric Covener <covener@gmail.com>
To: Apache HTTP Server Development List <dev@httpd.apache.org>
Content-Type: text/plain; charset=UTF-8

On Wed, Jun 25, 2014 at 8:24 AM,  <takashi@apache.org> wrote:
> Refactor asynchronous mod_proxy_wstunnel using pollfd returned by MPM.
> r1601943 and r1605307 made Event MPM return woken pollfd, so async
> wstunnel doesn't need its own apr_pollset_poll.

If both sockets are readable, we'll go all the way through
ap_mpm_register_socket_callback_timeout + locking queues and getting
dispatched to a new thread to read the 2nd socket.

I think this also prevents us from doing ProxyWebsocketAsyncDelay to
stay on the thread because we no longer have a poll during the
callback invocation.

-- 
Eric Covener
covener@gmail.com