Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3ABA011DC2 for ; Sat, 14 Jun 2014 19:29:51 +0000 (UTC) Received: (qmail 3814 invoked by uid 500); 14 Jun 2014 19:29:50 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 3757 invoked by uid 500); 14 Jun 2014 19:29:50 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 3747 invoked by uid 99); 14 Jun 2014 19:29:50 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Jun 2014 19:29:50 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy includes SPF record at spf.trusted-forwarder.org) Received: from [76.96.30.64] (HELO qmta07.emeryville.ca.mail.comcast.net) (76.96.30.64) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Jun 2014 19:29:45 +0000 Received: from omta17.emeryville.ca.mail.comcast.net ([76.96.30.73]) by qmta07.emeryville.ca.mail.comcast.net with comcast id EJrE1o0011afHeLA7KVLzd; Sat, 14 Jun 2014 19:29:20 +0000 Received: from [192.168.199.10] ([69.251.80.74]) by omta17.emeryville.ca.mail.comcast.net with comcast id EKVH1o0071cCKD98dKVJKs; Sat, 14 Jun 2014 19:29:19 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\)) Subject: Re: svn commit: r1602523 - in /httpd/httpd/trunk/modules/proxy: mod_proxy.c proxy_util.c From: Jim Jagielski In-Reply-To: Date: Sat, 14 Jun 2014 15:29:16 -0400 Cc: cvs@httpd.apache.org Content-Transfer-Encoding: 7bit Message-Id: <9D41BF2F-C651-45B9-89C0-C73B57929820@jaguNET.com> References: <20140613211052.51AC9238897A@eris.apache.org> To: dev@httpd.apache.org X-Mailer: Apple Mail (2.1878.2) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=comcast.net; s=q20140121; t=1402774160; bh=VJKjrZx0QmBjkub4fGkuNG2pKXKaKgQA/0CcHU9B10A=; h=Received:Received:Content-Type:Mime-Version:Subject:From:Date: Message-Id:To; b=vcxtmjK18bSWG5KAFLzILZsbt6SJo2S5IgfP/OeYlrEXJujB/KnmCw2lFDApZYJTW 3S5NFAmTp4GKx5I6vTfr8mY0x2crT6+FEDZpKQ+pHiaTsdhk2OKE5M6BDVZj25fnIu qgJ10I6JgmahhbLDVP3bybENDkOWZB4nTtzJ57R39H0NVVUcap5h3X94J6L49oHx9F 1N1C3Kfjc9JFXPRJT4gNIDfQzIqnzMHJ/v+voOAggR4L0uiH9YRdCNCumQbFUloC1o acjlY+25J/cs4CFxFsN55jOZhhJLKCQrOnBxBD94YJ5OAiiG1fbLOrlUSFPtjRzVwP YtcYXNXiLJKcw== X-Virus-Checked: Checked by ClamAV on apache.org On Jun 14, 2014, at 7:06 AM, Eric Covener wrote: > On Fri, Jun 13, 2014 at 5:10 PM, wrote: >> Allow for "magic" scheme "auto" which makes the scheme of >> the backend worker match whatever the scheme of the >> incoming request was... >> >> For example: >> >> ProxyPass / auto://foo.example.com/ >> >> If the incoming request is http:.../lala then >> the resultant will be http://foo.example.com/lala >> >> If it's wws:.../lolo then we'd send >> wws://foo.example.com/lolo > > > Does this work for websockets? Isn't the scheme http:// + Upgrade for > websockets? > > I thought "auto" would mean the handlers would second-guess the > scheme, but if we replace it in proxy_util.c they cannot do that > anymore. I thought the idea/issue was that we wanted, for example, an incoming http request to be handled by the http proxy scheme handler and if it was ws, to be handled by the ws scheme handler. This was not possible with the normal setup ProxyPass / http://foo.bar/ since all requests in this case would go to the http scheme handler (no matter what the incoming scheme was) as well as ProxyPass / ws://foo.bar/ Which would always go websockets, whether we wanted to or not. In other words, the incoming scheme determined the scheme we use on the backend, instead of it being "hard-coded" in the ProxyPass command. Not sure if I misunderstood or not :/