Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 7.3 \(1878.2\))
Subject: Re: svn commit: r1603863 - in /httpd/httpd/trunk/modules:
 aaa/mod_auth_basic.c http/http_filters.c
From: Jim Jagielski <jim@jaguNET.com>
In-Reply-To: 
 <CAKQ1sVOnxpG3d_5hXkfxQzX+Qd-UAw5ksi0SxKqvvAY=ry2_SA@mail.gmail.com>
Date: Fri, 20 Jun 2014 10:17:45 -0400
Cc: cvs@httpd.apache.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <6D153625-492F-404D-AEA5-D232425A0D9E@jaguNET.com>
References: <20140619124306.15BA0238899C@eris.apache.org>
 <410AA19E-760D-4808-88BF-97DAB69B1F72@jaguNET.com>
 <CAKQ1sVOxEF7T5Mydd98U83whO5EgqnRniruAAnVK_3_++V74JA@mail.gmail.com>
 <E28F80A3-799F-4BBD-A09C-9FE91955569A@jaguNET.com>
 <43A05E25-5C1F-4BB3-872E-070975BD2744@jaguNET.com>
 <CAKQ1sVOnxpG3d_5hXkfxQzX+Qd-UAw5ksi0SxKqvvAY=ry2_SA@mail.gmail.com>
To: dev@httpd.apache.org

What I meant was "true or false"... Sorry for the confusion.

On Jun 20, 2014, at 9:06 AM, Yann Ylavic <ylavic.dev@gmail.com> wrote:

> I can't agree with you on this.
>=20
> You first say a bit is either 0 or 1, which is not true for a signed
> bit (0 or -1), and confirms somehow we should use unsigned here.
> A good compiler should also complain about setting 1 to something that
> can only take 0 or -1, and we did that before this commit.
> The unambigous solution would be to use the bool type, but that's
> another story, and the closest alternative is to use *unsigned* bit
> field of size 1.
>=20
> BTW, I can revert this since the code using it does not compare the
> bit explicitely, but I find signed bit fields quite error prone if the
> value is not meant to be used for signed things (which isn't the case
> here).
>=20
> On Fri, Jun 20, 2014 at 1:51 PM, Jim Jagielski <jim@jagunet.com> =
wrote:
>> Besides that, any compiler worth its salt should complain.
>>=20
>> On Jun 20, 2014, at 7:50 AM, Jim Jagielski <jim@jaguNET.com> wrote:
>>=20
>>> Who does that w/ bit fields? You either check if it's
>>> true/false or you use the expected bit operations.
>>>=20
>>> On Jun 19, 2014, at 9:29 AM, Yann Ylavic <ylavic.dev@gmail.com> =
wrote:
>>>=20
>>>> On Thu, Jun 19, 2014 at 2:59 PM, Jim Jagielski <jim@jagunet.com> =
wrote:
>>>>>=20
>>>>> On Jun 19, 2014, at 8:43 AM, ylavic@apache.org wrote:
>>>>>=20
>>>>>> Author: ylavic
>>>>>> Date: Thu Jun 19 12:43:05 2014
>>>>>> New Revision: 1603863
>>>>>>=20
>>>>>> URL: http://svn.apache.org/r1603863
>>>>>> Log:
>>>>>> Use unsigned bit flags (otherwise the non-zero value to be used =
is -1).
>>>>>>=20
>>>>>=20
>>>>> I don't understand that at all... A bit is either 1 or 0.
>>>>>=20
>>>>=20
>>>> Well, it depends on what you are doing with that bit...
>>>>=20
>>>> #include <stdio.h>
>>>> int main(int argc, const char *argv[])
>>>> {
>>>>  struct {
>>>>      int s:1;
>>>>  } bitfield;
>>>>=20
>>>>  bitfield.s =3D 1;
>>>>  if (bitfield.s > 0) {
>>>>      printf("positive\n");
>>>>  }
>>>>  else {
>>>>      printf("negative or nul\n");
>>>>  }
>>>>  if (bitfield.s =3D=3D 1) {
>>>>      printf("one\n");
>>>>  }
>>>>  else {
>>>>      printf("not one\n");
>>>>  }
>>>>=20
>>>>  return 0;
>>>> }
>>>>=20
>>>> $ ./bitfield
>>>> negative or nul
>>>> not one
>>>>=20
>>>=20
>>=20
>=20