httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1598946 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_fdpass.c
Date Mon, 16 Jun 2014 20:27:23 GMT
Applied in r1602989.

On Fri, Jun 13, 2014 at 1:45 AM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
> On Fri, Jun 13, 2014 at 1:20 AM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
>> On Fri, Jun 13, 2014 at 1:09 AM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
>>> On Fri, Jun 13, 2014 at 12:32 AM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
>>>> The most important imho is to not truncate the length at sizeof(struct
>>>> sockaddr_un) when the real sun_path is beyond sizeof(sun_path).
>>>> The libc calls are probably bullet proof regarding NUL termination
>>>> (eg. force ((char*)sun)[addrlen] = 0 and recompute the length like in
>>>> the linux code from your link above), setting the NUL ourself at the
>>>> good place seems reasonable though ;)
>>>
>>> Hence I think the correct behaviour is in mod_cgid, and something like
>>> the following patch should be applied :
>>
>> This one is better :
>
> Well, finally, how about this one (the full monty, attached)?

Mime
View raw message