httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1601291 - in /httpd/httpd/trunk: CHANGES docs/log-message-tags/next-number modules/proxy/proxy_util.c
Date Tue, 10 Jun 2014 13:02:04 GMT
On Tue, Jun 10, 2014 at 2:46 PM, Takashi Sato <takashi@tks.st> wrote:
> r1601291 causes SEGV.
>
> # Failed test 2 in t/ssl/proxy.t at line 56
> # Failed test 115 in t/ssl/proxy.t at line 56 fail #3
> [  error] oh gosh, server dumped core
> [  error] for stacktrace, run: gdb /home/st/c99fix/apache/bin/httpd
> -core /home/st/c99fix/httpd-test/t/core.3649
> [  error] oh nuts, server dumped core again
> [  error] for stacktrace, run: gdb /home/st/c99fix/apache/bin/httpd
> -core /home/st/c99fix/httpd-test/t/core.3647
> t/ssl/proxy.t .......................
> Failed 2/172 subtests
>
> The new function connection_shutdown is a pool cleanup func.
> connection_shutdown calls ap_shutdown_conn,
> but ap_shutdown_conn finally calls apr_pool_clear!
> (see attached strack trace)

Ouch, thanks, deferred_write_pool has to be alive...

Will fix with :
Index: modules/proxy/proxy_util.c
===================================================================
--- modules/proxy/proxy_util.c    (revision 1601598)
+++ modules/proxy/proxy_util.c    (working copy)
@@ -2917,8 +2917,7 @@ PROXY_DECLARE(int) ap_proxy_connection_create(cons
     /* Shutdown the connection before closing it (eg. SSL connections
      * need to be close-notify-ed).
      */
-    apr_pool_cleanup_register(conn->scpool, conn, connection_shutdown,
-                              apr_pool_cleanup_null);
+    apr_pool_pre_cleanup_register(conn->scpool, conn, connection_shutdown);

     return OK;
 }
[END]
which was my original version...

Mime
View raw message