httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: Memory leak in mod_ssl ssl_callback_TmpDH
Date Thu, 29 May 2014 12:33:39 GMT
On Wed, May 28, 2014 at 10:10:16PM +0200, Ruediger Pluem wrote:
> Thanks, but I missed some stuff during review:
> 
> 1. We don't need to have two DH pointers in make_dh_params

Doh! 

> 2. There possible frees on NULL pointers in free_dh_params:

This is unnecessary because DH_free() does that already, but that 
deserves a comment too.  I'll fix this with your patch for (1) shortly, 
thanks!

Mime
View raw message