Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2D78E1184A for ; Mon, 14 Apr 2014 12:04:12 +0000 (UTC) Received: (qmail 32644 invoked by uid 500); 14 Apr 2014 12:04:10 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 32113 invoked by uid 500); 14 Apr 2014 12:04:09 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 32099 invoked by uid 99); 14 Apr 2014 12:04:08 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Apr 2014 12:04:08 +0000 X-ASF-Spam-Status: No, hits=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of jorton@redhat.com designates 209.132.183.28 as permitted sender) Received: from [209.132.183.28] (HELO mx1.redhat.com) (209.132.183.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 14 Apr 2014 12:04:03 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id s3EC3dfk010252 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK) for ; Mon, 14 Apr 2014 08:03:39 -0400 Received: from iberis (vpn-48-162.rdu2.redhat.com [10.10.48.162]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id s3EC3bI6012594 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO) for ; Mon, 14 Apr 2014 08:03:38 -0400 Received: from jorton by iberis with local (Exim 4.80.1) (envelope-from ) id 1WZfbt-00048e-5p for dev@httpd.apache.org; Mon, 14 Apr 2014 13:03:37 +0100 Date: Mon, 14 Apr 2014 13:03:37 +0100 From: Joe Orton To: dev@httpd.apache.org Subject: Re: [PATCH] mod_ssl APIs to allow implementation of Certificate Transparency as a separate mod Message-ID: <20140414120337.GA11816@redhat.com> Mail-Followup-To: dev@httpd.apache.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Organization: Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham (US), Paul Hickey (Ireland), Matt Parson (US), Charles Peters (US) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Virus-Checked: Checked by ClamAV on apache.org On Sat, Apr 12, 2014 at 09:00:08AM -0400, Jeff Trawick wrote: > So... Concerns? Suggestions? Etc.? Speak up, or forever* ask me to fix > it after committing ;) (*Let's not be ridiculous though) Interesting stuff! I do think it is preferable to keep mod_ssl.h toolkit-agnostic. Because the API you are adding is not indended to be "private", I'd suggest mod_ssl_openssl.h or something like that instead. Regards, Joe