httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Covener <cove...@gmail.com>
Subject Re: svn commit: r1584417 - in /httpd/httpd/trunk: docs/manual/rewrite/flags.xml modules/mappers/mod_rewrite.c
Date Sat, 05 Apr 2014 18:42:27 GMT
Thanks to both of you for reviews. I added a flag in 1585157 that
controls how it handles ' ' in both paths.

I also renamed the little stack method since this is the only caller.


On Fri, Apr 4, 2014 at 8:13 AM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
> On Fri, Apr 4, 2014 at 1:15 PM, Eric Covener <covener@gmail.com> wrote:
>> However this is another part of the escaping here that is wrong half the
>> time.  It you're not substituting into the query string, we want c2x.
>
> Agreed, POST vars spaces (application/x-www-form-urlencoded) for
> example should be %20-encoded (although it's not always observed).
> IMHO, '+' vs %20 deserves its own escape_uri() arg.



-- 
Eric Covener
covener@gmail.com

Mime
View raw message