httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: svn commit: r1584941 - /httpd/httpd/branches/2.4.x/STATUS
Date Sat, 05 Apr 2014 11:59:23 GMT
First, thanks for looking!

On Sat, Apr 5, 2014 at 2:24 AM, Marion & Christophe JAILLET <
christophe.jaillet@wanadoo.fr> wrote:

> Hi,
>
> I've gone quickly thru the module and I have a few remarks:
>     - What is the use of FN_LOG_MARK on line 87? Couldn't we use
> APLOG_MARK instead?
>       'connect_to_peer' is called only in one place with
> module_index=APLOG_MODULE_INDEX
>

The idea behind that was that connect_to_peer could be more generally
useful, and the calling module should identify itself to improve logging.
 But that is easy enough to restore if it ever moves to a common location
and becomes an API.  Fixed in r1585054.


>
>    - Do things like AP_MODULE_MAGIC_AT_LEAST(20130702,2) on line 186 and
> 228 are meaningful?
>      I mean, is there a link between the value of
> MODULE_MAGIC_NUMBER_MAJOR on trunk and on stable branch?
>      Should patches related to 'ap_log_rdata' be merged first?
>

It keeps the code from being enabled in the 2.4.x branch and allows it to
be tied to a particular MMN in trunk for the explanation (though the
purpose of hiding the code is pretty obvious).

IMO these particular logs aren't critical in the short term, though I would
like to see genuine interest (i.e., callers in trunk) in ap_log_*data() and
get those APIs merged back into 2.4.x at some point.

I'd prefer to keep the code as-is for now, and don't think the
ap_log_*data() stuff has to be merged first.


>    - Maybe temp_pool in 'req_rsp' could be kept till the end of the
> function and table 'vars' (line 784) allocated from there ?
>

That looks good to me...   r1585072

Thanks!


>
> CJ
>
>
> Le 05/04/2014 01:44, trawick@apache.org a écrit :
>
>  Author: trawick
>> Date: Fri Apr  4 23:44:32 2014
>> New Revision: 1584941
>>
>> URL: http://svn.apache.org/r1584941
>> Log:
>> mod_authnz_fcgi...
>>
>> Modified:
>>      httpd/httpd/branches/2.4.x/STATUS
>>
>> Modified: httpd/httpd/branches/2.4.x/STATUS
>> URL: http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/
>> STATUS?rev=1584941&r1=1584940&r2=1584941&view=diff
>> ============================================================
>> ==================
>> --- httpd/httpd/branches/2.4.x/STATUS (original)
>> +++ httpd/httpd/branches/2.4.x/STATUS Fri Apr  4 23:44:32 2014
>> @@ -239,6 +239,11 @@ PATCHES PROPOSED TO BACKPORT FROM TRUNK:
>>        2.4.x patch: trunk works (modulo CHANGES)
>>        +1: ylavic
>>   +   * Merge mod_authnz_fcgi from trunk.
>> +     http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/aaa/
>> mod_authnz_fcgi.c
>> +     http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/manual/
>> mod/mod_authnz_fcgi.xml
>> +     +1: trawick
>> +
>>   OTHER PROPOSALS
>>        * A list of further possible backports can be found at:
>>
>>
>>
>>
>


-- 
Born in Roswell... married an alien...
http://emptyhammock.com/
http://edjective.org/

Mime
View raw message