Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (nike.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
References: <1393617163.75723.YahooMailNeo@web172804.mail.ir2.yahoo.com>
 <CALK=YjN7ocjYU0fxfcJo3yzsG_RFDoL3B9K6V7TK87go6+DWyA@mail.gmail.com>
 <9DE4A33D-1E30-47D8-A966-E1BAC139925B@jellybaby.net>
 <7A1BD74D-CC6A-4128-A9B4-6EB8A31CBB88@jellybaby.net>
Mime-Version: 1.0 (1.0)
In-Reply-To: <7A1BD74D-CC6A-4128-A9B4-6EB8A31CBB88@jellybaby.net>
Content-Type: text/plain;
	charset=utf-8
Content-Transfer-Encoding: quoted-printable
Message-Id: <5650D2C9-3C7B-40F5-B229-2EAC4AB7082F@yahoo.co.uk>
Cc: "dev@httpd.apache.org" <dev@httpd.apache.org>
From: Kevin Gale <s7g2vp2@yahoo.co.uk>
Subject: Re: Improving The RewriteMap Program Feature
Date: Tue, 4 Mar 2014 08:58:16 +0000
To: "dev@httpd.apache.org" <dev@httpd.apache.org>

Hi Tim

What are the chances of getting this into the next release of Apache?

Kev

> On 2 Mar 2014, at 17:03, Tim Bannister <isoma@jellybaby.net> wrote:
>=20
>> On 2 Mar 2014, at 16:46, Tim Bannister <isoma@jellybaby.net> wrote:
>>=20
>> On 1 Mar 2014, at 12:20, Eric Covener <covener@gmail.com> wrote:
>>=20
>>>> If the RewriteMap Program fails, the code within mod_rewrite returns an=

>>>> empty string rather than NULL. In my tests this caused /index.htm to be=

>>>> returned as the URL which is not very useful. I think it makes more sen=
se to
>>>> handle this situation as a NULL so that the default key is used as we c=
ould
>>>> then provide a backup method.
>>>> eg:
>>>>   RewriteRule ^/proxy/(.*) ${proxymap:$1|/proxybackup/$1} [P]
>>>>   RewriteRule ^/proxybackup/(.*) /proxybackup.php?url=3D$1 [L]
>>>>=20
>>>> Looking at the mod_rewrite source code this appears to be a one liner c=
hange
>>>> in lookup_map_program:
>>>>   if (i =3D=3D 4 && !strcasecmp(buf, "NULL"))
>>>>   .....
>>>> becomes:
>>>>   if ((i =3D=3D 0) || (i =3D=3D 4 && !strcasecmp(buf, "NULL"))) {
>>>>   .....
>>>>=20
>>>> Is this minor change something that you would consider implementing?
>>>=20
>>> I think it would need to be opt-in in 2.4, as changing it could break
>>> configs depending on the current behavior.    Maybe some extra flag on
>>> the definition of the RewriteMap or a RewriteOption?
>>=20
>> Here's how I'd want it:
>>=20
>> RewriteMap foo prgfb:/www/bin/example.pl
>>=20
>> (prgfb =E2=80=94 program with fallback).
>=20
> In other words, a user could choose =E2=80=9Cprg=E2=80=9D or =E2=80=9Cprgf=
b=E2=80=9D. prg selects the legacy, httpd-2.0 behaviour. prgfb selects a new=
 behaviour which handles map program failure as NULL.
>=20
> Eventually (2.6?), httpd could merge =E2=80=9Cprg=E2=80=9D and =E2=80=9Cpr=
gfb=E2=80=9D into a single map type.
>=20
>=20
> --=20
> Tim Bannister =E2=80=93 isoma@jellybaby.net
>=20