httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Plüm, Rüdiger, Vodafone Group <ruediger.pl...@vodafone.com>
Subject AW: svn commit: r1582858 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/lua/lua_apr.c modules/lua/lua_apr.h modules/lua/lua_request.c modules/lua/lua_request.h
Date Fri, 28 Mar 2014 20:39:49 GMT


> -----Ursprüngliche Nachricht-----
> Von: Daniel Gruno 
> Gesendet: Freitag, 28. März 2014 21:34
> An: dev@httpd.apache.org
> Betreff: Re: svn commit: r1582858 - in /httpd/httpd/trunk: docs/log-
> message-tags/next-number modules/lua/lua_apr.c modules/lua/lua_apr.h
> modules/lua/lua_request.c modules/lua/lua_request.h
> 
> On 03/28/2014 09:29 PM, Ruediger Pluem wrote:
> 
> >
> > Why this check if we already use t->r->pool above :-)?
> >
> >> +            ap_log_rerror(APLOG_MARK, APLOG_WARNING, 0, t->r,
> >> +                APLOGNO(02614) "mod_lua: Value for '%s' in table
> '%s' contains newline!",
> >> +                  key, t->n);
> >> +        }
> >> +        apr_table_set(t->t, key, replacement);
> >> +    }
> >> +    else {
> >> +        apr_table_set(t->t, key, val);
> >>      }
> >> -    apr_table_set(t, key, val);
> >>      return 0;
> >>  }
> >
> > Regards
> >
> > Rüdiger
> >
> 
> Brain fart, apologies :)
> Since we're already NOT fixing up any table called 'notes', we have no
> need to check if t->r is set, since it will only be NULL in the (super
> secret, hidden) connection notes table.

Maybe you should put a comment regarding this above the block, why it is not needed to check
for r != NULL.

Regards

Rüdiger

Mime
View raw message