httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Rainer Jung <rainer.j...@kippdata.de>
Subject Re: svn commit: r1583175 - /httpd/httpd/trunk/modules/mappers/mod_alias.c
Date Mon, 31 Mar 2014 10:00:06 GMT
On 30.03.2014 22:52, Eric Covener wrote:
> On Sun, Mar 30, 2014 at 4:13 PM, Rainer Jung <rainer.jung@kippdata.de> wrote:

>>> AFAICT {
>>> In as much that it was ever useful, this breaks people relying on the
>>> "context info" for aliasmatches structured the way this code was
>>> originally biased to expecting:
>>> 
>>>   AliasMatch ^(/foo/bar/)(.*) /var/www/baz/$1
>>> 
>>> IMO might be best to just never set context info here, or not set it
>>> when the first capture is not starting at offset 0.
>>> }

>> What would have been the expected prefix value in this case?
> 
> Sorry, got myself mixed up with regm[0], it's the entire match not a capture.
> 
> Once you have a trailing wildcard like that, this code will think the
> entire request path was the prefix.

Still I don't understand what a correct "prefix" would be. I don't get
the idea behind the prefix.

>> What in the AliasMatch / /some/thing case?
> 
> For "AliasMatch / /some/thing", a prefix of "/" makes sense but
> nothing will ever be meaningful for the context document root.
> 
> Is there any AliasMatch that does produce a meaningul prefix and
> context document root? It makes sense that it could never know.

So you suggest to remove ap_set_context_info() from the AliasMatch handling?

Regards,

Rainer

Mime
View raw message