httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: Behavior of Host: vs. SNI Hostname in proxy CONNECT requests
Date Mon, 24 Feb 2014 17:25:53 GMT
I see, makes sense.
Thanks, I'll think about it if/when we agree on a commit.

On Mon, Feb 24, 2014 at 6:19 PM, William A. Rowe Jr. <wmrowe@gmail.com> wrote:
> On Mon, Feb 24, 2014 at 10:57 AM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
>>>
>>> This could be a worthwhile idea and I have seen your patch in bugzilla.
>>> For ease of commenting I would like you to post it here such that inline comments
could
>>> be made (I would have some).
>>
>> Here it is (thanks for looking into this).
>>
>> Index: modules/proxy/mod_proxy.h
>> ===================================================================
>> --- modules/proxy/mod_proxy.h (revision 1569048)
>> +++ modules/proxy/mod_proxy.h (working copy)
>> @@ -242,6 +242,7 @@ typedef struct {
>>      apr_pool_t   *pool;        /* Subpool for hostname and addr data */
>>      const char   *uds_path;    /* Unix domain socket path */
>>      const char   *hostname;
>> +    const char   *ssl_hostname;
>>      apr_sockaddr_t *addr;      /* Preparsed remote address info */
>>      apr_pool_t   *scpool;      /* Subpool used for socket and
>> connection data */
>>      apr_socket_t *sock;        /* Connection socket */
>
>
> Just a quick reminder to all new committers, any extensions to public
> structures have their new members added to the end of the structure,
> not inserted.  This allows most modules to consume the same structure
> without recompilation.  Extending requires an MMN minor bump, but
> inserting or removing a member demands a major mmn bump.

Mime
View raw message