httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Kaluža <>
Subject Re: PR 50335 missing patch?
Date Thu, 27 Feb 2014 12:07:22 GMT
On 02/27/2014 12:35 PM, Yann Ylavic wrote:
> Hi,
> the patch proposed by Rüdiger at
> has not
> been commited in trunk (nor backported...).
> Shouldn't it to fully address the issue?

I think that just this patch wouldn't fix this particular PR (because 
the part of code causing crashes doesn't use ap_proxy_pass_brigade), but 
I think we should commit it.

The patch makes sense and code calling ap_proxy_pass_brigade apparently 
does not do anything with the bucket_brigade when ap_proxy_pass_brigade 
fails, so it's OK to call cleanup.

> It seems that the error path is concerned too (since conn->scpool is
> still destroyed before r->pool).
> Regards;
> Yann.

Jan Kaluza

View raw message