Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: local policy includes SPF record at
 spf.trusted-forwarder.org)
Content-Type: text/plain; charset=iso-8859-1
Mime-Version: 1.0 (Mac OS X Mail 7.2 \(1865.1\))
Subject: Re: svn commit: r1561385 -
 /httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c
From: Jim Jagielski <jim@jaguNET.com>
In-Reply-To: <EABC1D36-9745-45AF-91D0-9EC6183FF3AA@jaguNET.com>
Date: Wed, 29 Jan 2014 10:02:53 -0500
Cc: apr <dev@apr.apache.org>
Content-Transfer-Encoding: quoted-printable
Message-Id: <3D5B1DD5-74EA-44D8-BB42-9675220D418B@jaguNET.com>
References: <20140125201150.8F51323889E0@eris.apache.org>
 <CAKUrXK7O+fas69J7rti0=mTR9V-foq+3vpmVBuWU7M8HvN1Xyg@mail.gmail.com>
 <EABC1D36-9745-45AF-91D0-9EC6183FF3AA@jaguNET.com>
To: dev@httpd.apache.org

But I would prefer others testing as well...

It's worth noting that it's just slotmem which did
this and so, if it was "required" any other use of
shared mem which child processes needed to have access
to cross forks would be broken. And it was just the SysV
shm which did this.

I *still* think that APR should backport the set_perm stuff
from trunk to 1.5, but I think that breaks ABI. But *that's*
where it belongs (in apr, not httpd).

On Jan 29, 2014, at 7:33 AM, Jim Jagielski <jim@jaguNET.com> wrote:

> Yes, it still works (at least in all my testing) :)
>=20
> On Jan 28, 2014, at 12:48 PM, Jeff Trawick <trawick@gmail.com> wrote:
>=20
>> On Sat, Jan 25, 2014 at 3:11 PM, <jim@apache.org> wrote:
>> Author: jim
>> Date: Sat Jan 25 20:11:50 2014
>> New Revision: 1561385
>>=20
>> URL: http://svn.apache.org/r1561385
>> Log:
>> Remove wonky and unneeded code. We have access
>> cross forks, so child processes have access.
>>=20
>> I see that you are saying it is okay, but I have to ask anyway:  For =
SysV shared memory specifically, apr_shm_attach() in the child still =
works when parent is root and child is not root?
>>=20
>>=20
>> When we need true external access, this is something
>> that APR shm must provide. We should have no
>> knowledge of APR internals.
>>=20
>> Modified:
>>    httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c
>>=20
>> Modified: httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c
>> URL: =
http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/slotmem/mod_slotmem=
_shm.c?rev=3D1561385&r1=3D1561384&r2=3D1561385&view=3Ddiff
>> =
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D
>> --- httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c (original)
>> +++ httpd/httpd/trunk/modules/slotmem/mod_slotmem_shm.c Sat Jan 25 =
20:11:50 2014
>> @@ -88,40 +88,6 @@ static apr_pool_t *gpool =3D NULL;
>> #define DEFAULT_SLOTMEM_SUFFIX ".shm"
>> #define DEFAULT_SLOTMEM_PERSIST_SUFFIX ".persist"
>>=20
>> -/* apr:shmem/unix/shm.c */
>> -static apr_status_t unixd_set_shm_perms(const char *fname)
>> -{
>> -#ifdef AP_NEED_SET_MUTEX_PERMS
>> -#if APR_USE_SHMEM_SHMGET || APR_USE_SHMEM_SHMGET_ANON
>> -    struct shmid_ds shmbuf =3D { { 0 } };
>> -    key_t shmkey;
>> -    int shmid;
>> -
>> -    shmkey =3D ftok(fname, 1);
>> -    if (shmkey =3D=3D (key_t)-1) {
>> -        return errno;
>> -    }
>> -    if ((shmid =3D shmget(shmkey, 0, SHM_R | SHM_W)) =3D=3D -1) {
>> -        return errno;
>> -    }
>> -#if MODULE_MAGIC_NUMBER_MAJOR <=3D 20081212
>> -#define ap_unixd_config unixd_config
>> -#endif
>> -    shmbuf.shm_perm.uid  =3D ap_unixd_config.user_id;
>> -    shmbuf.shm_perm.gid  =3D ap_unixd_config.group_id;
>> -    shmbuf.shm_perm.mode =3D 0600;
>> -    if (shmctl(shmid, IPC_SET, &shmbuf) =3D=3D -1) {
>> -        return errno;
>> -    }
>> -    return APR_SUCCESS;
>> -#else
>> -    return APR_ENOTIMPL;
>> -#endif
>> -#else
>> -    return APR_ENOTIMPL;
>> -#endif
>> -}
>> -
>> /*
>>  * Persist the slotmem in a file
>>  * slotmem name and file name.
>> @@ -413,15 +379,6 @@ static apr_status_t slotmem_create(ap_sl
>>         if (rv !=3D APR_SUCCESS) {
>>             return rv;
>>         }
>> -        if (fbased) {
>> -            /* Set permissions to shared memory
>> -             * so it can be attached by child process
>> -             * having different user credentials
>> -             *
>> -             * See apr:shmem/unix/shm.c
>> -             */
>> -            unixd_set_shm_perms(fname);
>> -        }
>>         ptr =3D (char *)apr_shm_baseaddr_get(shm);
>>         desc.size =3D item_size;
>>         desc.num =3D item_num;
>>=20
>>=20
>>=20
>>=20
>>=20
>> --=20
>> Born in Roswell... married an alien...
>> http://emptyhammock.com/
>=20