httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Covener <cove...@gmail.com>
Subject Re: svn commit: r1557580 - in /httpd/httpd/trunk: docs/manual/mod/mod_speling.xml modules/mappers/mod_speling.c
Date Sat, 18 Jan 2014 20:43:54 GMT
On Sun, Jan 12, 2014 at 1:11 PM,  <jailletc36@apache.org> wrote:
> -#ifdef WANT_BASENAME_MATCH
> +        else if ((cfg->check_case_only == 0) &&
> +                 (cfg->check_basename_match == 1)) {


Did you consider that given how long it has worked the other way, that
"CheckCaseOnly" was only meant to short circuit the more expensive
spelling search rather than this quick basename check?  I am thinking
the case+baname only should be a valid combination.

-- 
Eric Covener
covener@gmail.com

Mime
View raw message