httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Darroch <chr...@pearsoncmg.com>
Subject Re: svn commit: r1557640 - in /httpd/httpd/trunk: CHANGES docs/manual/mod/mod_dir.xml modules/mappers/mod_dir.c
Date Mon, 13 Jan 2014 19:55:33 GMT
covener@apache.org wrote:

> restore http://svn.apache.org/viewvc?view=revision&revision=233369 
> under a configurable option: don't run mod_dir if r->handler is already set.
> PR53794

   I like this, and it's certainly a more configurable solution to
the problem with mod_dav which came up last week:

http://marc.info/?l=apache-httpd-dev&m=138842871710848&w=2

   The only problem I see here (without having testing the new changes)
is that I believe the default will be to preserve the prior 2.4.x
behaviour:

> +    new->checkhandler = MODDIR_UNSET;

> +    if (d->checkhandler == MODDIR_ON && strcmp(r->handler, DIR_MAGIC_TYPE))
{
> +        return DECLINED;
> +    }

   For users of mod_dav, though, this means that a working 2.2.x
configuration will still break after an upgrade to 2.4.8; they'd
need to add in "DirectoryCheckHandler On".

   I'd like to my additional line of logic, if you agree:

+    if (r->method_number != M_GET && r->method_number != M_POST) {
+        return DECLINED;
+    }

which would ensure that for mod_dir takes no effect when the method
is neither GET nor POST, which seems reasonable to me (since it has
no real meaning with other methods), and has the effect that 2.2.x DAV
setups will "just work" again with 2.4.x, once the patch is back-ported.

   Does that seem acceptable to you?  I can just follow CTR, I know, but
I thought I'd ask first since you're clearly looking at similar issues
at the same time.

Chris.

-- 
GPG Key ID: 088335A9
GPG Key Fingerprint: 86CD 3297 7493 75BC F820  6715 F54F E648 0883 35A9


Mime
View raw message