httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Kean Johnston <kean.johns...@gmail.com>
Subject Re: Ceph patches for httpd
Date Thu, 02 Jan 2014 16:04:08 GMT
On 12/30/2013 10:07 PM, Justin Erenkrantz wrote:
> On Sun, Dec 29, 2013 at 3:48 PM, Jim Jagielski <jim@jagunet.com> wrote:
> Index: modules/http/http_filters.c
> ===================================================================
> --- modules/http/http_filters.c (revision 1554304)
> +++ modules/http/http_filters.c (working copy)
> @@ -1254,7 +1254,7 @@ AP_CORE_DECLARE_NONSTD(apr_status_t) ap_http_heade
>       if (r->header_only
>           && (clheader = apr_table_get(r->headers_out, "Content-Length"))
>           && !strcmp(clheader, "0")
> -        && conf->http_cl_head_zero != AP_HTTP_CL_HEAD_ZERO_ENABLE) {
> +        && conf->http_cl_head_zero == AP_HTTP_CL_HEAD_ZERO_DISABLE) {
>           apr_table_unset(r->headers_out, "Content-Length");
>       }
>
Why don't you move the integer comparison to ahead of the apr_table_get and 
strcmp()? That way relatively expensive options get boolean short-circuited.

Kean

Mime
View raw message