httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Covener <cove...@gmail.com>
Subject Re: ProxyPass in <directory>... why not??
Date Wed, 11 Dec 2013 22:09:01 GMT
On Mon, Dec 9, 2013 at 2:02 PM, Jim Jagielski <jim@jagunet.com> wrote:
> We know that ProxyPass works in <Location>, since it was
> added in http://svn.apache.org/viewvc?view=revision&revision=1026184.
>
> However, the very next patch (http://svn.apache.org/viewvc?view=revision&revision=1031758)
> prevents it from working in <Directory> (as well as <Files>, but I'm
> ignoring that)...
>
> My question is why? From what I can see, the only reason
> is to close https://issues.apache.org/bugzilla/show_bug.cgi?id=47765
> but I again wonder why we allow Location but not Directory?

> Anyone have any further info on why? And yes, this is related
> to https://issues.apache.org/bugzilla/show_bug.cgi?id=54965

My recollection was that it simply doesn't work (PR and quick test)
So I tried to split it into a "don't silently fail to proxy" PR and a
"please support this" PR.

Proxy stakes its claim to a request in translate_name, which is after
the location walk but before the directory/file walk. So it makes
sense that is sees no configuration there given the current impl of
storing the per-directory ProxyPass in actual per-directory config.

The fix would need to include (I think?) some way of normalizing or
ignoring cmd->path, which is used instead of the first parm but
doesn't make much sense in terms of <Directory>.

But I am not so invested in any of it, so if something works for you
in sandbox no qualms here with changes.

Mime
View raw message