httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: Behavior of Host: vs. SNI Hostname in proxy CONNECT requests
Date Mon, 23 Dec 2013 20:49:09 GMT


Kaspar Brand wrote:
> On 21.12.2013 14:21, Ruediger Pluem wrote:
>>> I guess a more general fix for this would be:
>>
>> No further comments / feedback? If not then I would commit the patch.
> 
> The change looks fine to me (for easier comparison/review,
> a whitespace-change-ignoring version is attached).
> 
> What would probably make sense is to amend the following comment
> on this occasion:
> 
>   /*
>    * The SNI extension supplied a hostname. So don't accept requests
>    * with either no hostname or a different hostname.
>    */
> 
> It doesn't say anything about the rationale right now, and as
> recent discussions have shown, it would be helpful to explain
> why this is done.

Done. I have tried to improve the comment and added a TODO if my
reasoning for the checks is really true.

Regards

RĂ¼diger


Mime
View raw message