Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (nike.apache.org: domain of trawick@gmail.com designates
 209.85.217.181 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <52853C6E.5070802@oracle.com>
References: <52853C6E.5070802@oracle.com>
Date: Fri, 15 Nov 2013 12:38:29 -0500
Message-ID: 
 <CAKUrXK4o1yNoU6Pn-1Cca5pN3Dg4iar9wEhQt8Ep2y=XSKB7Ow@mail.gmail.com>
Subject: Re: False positive errno test after call to strtol()
From: Jeff Trawick <trawick@gmail.com>
To: Apache HTTP Server Development List <dev@httpd.apache.org>
Content-Type: multipart/alternative; boundary=001a11c381569b3c6404eb3aaac1

--001a11c381569b3c6404eb3aaac1
Content-Type: text/plain; charset=ISO-8859-1

On Thu, Nov 14, 2013 at 4:11 PM, Mike Rumph <mike.rumph@oracle.com> wrote:

> The man page for strtol() indicate that the function can set errno to
> ERANGE (EINVAL is also possible for some environments).
> But for the errno check to be valid errno should be set to 0 before the
> function call.
> - http://linux.die.net/man/3/strtol
>
> I've reviewed all cases of calls to strtol() in httpd and APR code.
> In some cases no validation is performed after the call.
> In most cases endptr (the second parameter) is checked against the
> beginning and/or ending of the string which does not guarantee against
> numeric overflow.
> In some cases errno is checked for ERANGE.
>
> I've attached a patch for the simplest case, where errno is checked but
> was not set to 0 before the call.
>

committed to trunk as r1542338; I'll propose for backport to the 2.4.x
branch


>
> I will consider working up a more extensive patch, if it is desired.
>

I suggest posting a couple of examples of what you found first.


>
> BTW, this discussion is not purely theoretical.
> Erroneous "Invalid ThreadStackSize value: " messages have been witnessed
> in HP-UX environments.
>
> Thanks,
>
> Mike Rumph
>


-- 
Born in Roswell... married an alien...
http://emptyhammock.com/

--001a11c381569b3c6404eb3aaac1
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div dir=3D"ltr">On Thu, Nov 14, 2013 at 4:11 PM, Mike Rumph <span dir=3D"l=
tr">&lt;<a href=3D"mailto:mike.rumph@oracle.com" target=3D"_blank">mike.rum=
ph@oracle.com</a>&gt;</span> wrote:<br><div class=3D"gmail_extra"><div clas=
s=3D"gmail_quote">
<blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;border-left:1p=
x #ccc solid;padding-left:1ex">The man page for strtol() indicate that the =
function can set errno to ERANGE (EINVAL is also possible for some environm=
ents).<br>

But for the errno check to be valid errno should be set to 0 before the fun=
ction call.<br>
- <a href=3D"http://linux.die.net/man/3/strtol" target=3D"_blank">http://li=
nux.die.net/man/3/<u></u>strtol</a><br>
<br>
I&#39;ve reviewed all cases of calls to strtol() in httpd and APR code.<br>
In some cases no validation is performed after the call.<br>
In most cases endptr (the second parameter) is checked against the beginnin=
g and/or ending of the string which does not guarantee against numeric over=
flow.<br>
In some cases errno is checked for ERANGE.<br>
<br>
I&#39;ve attached a patch for the simplest case, where errno is checked but=
 was not set to 0 before the call.<br></blockquote><div><br></div><div>comm=
itted to trunk as r1542338; I&#39;ll propose for backport to the 2.4.x bran=
ch</div>
<div>=A0</div><blockquote class=3D"gmail_quote" style=3D"margin:0 0 0 .8ex;=
border-left:1px #ccc solid;padding-left:1ex">
<br>
I will consider working up a more extensive patch, if it is desired.<br></b=
lockquote><div><br></div><div>I suggest posting a couple of examples of wha=
t you found first.</div><div>=A0</div><blockquote class=3D"gmail_quote" sty=
le=3D"margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
BTW, this discussion is not purely theoretical.<br>
Erroneous &quot;Invalid ThreadStackSize value: &quot; messages have been wi=
tnessed in HP-UX environments.<br>
<br>
Thanks,<br>
<br>
Mike Rumph<br>
</blockquote></div><br><br clear=3D"all"><div><br></div>-- <br>Born in Rosw=
ell... married an alien...<br><a href=3D"http://emptyhammock.com/" target=
=3D"_blank">http://emptyhammock.com/</a><br>
</div></div>

--001a11c381569b3c6404eb3aaac1--