Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of bert@qqmail.nl designates
 74.125.83.54 as permitted sender)
From: "Bert Huijben" <bert@qqmail.nl>
To: <dev@httpd.apache.org>
References: <745AFCC4-CA7C-4FEC-9D4A-5B3E2263D44E@sharp.fm>
 <AB1691BE05AE7F4992697F2A0835627A948B507E@VOEXM10W.internal.vodafone.com>
 <40C2A8E4-412F-4FA8-8B36-E5BB0CA8CA85@sharp.fm>
In-Reply-To: <40C2A8E4-412F-4FA8-8B36-E5BB0CA8CA85@sharp.fm>
Subject: RE: [Patch] non blocking writes in core
Date: Tue, 19 Nov 2013 22:58:21 +0100
Message-ID: <013c01cee572$77a46ce0$66ed46a0$@qqmail.nl>
MIME-Version: 1.0
Content-Type: text/plain;
	charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Thread-Index: AQIsdc/BTrni4RnEEBSVzlTehwRT7wFhYjZrAQDUlKGZXucskA==
Content-Language: nl

> -----Original Message-----
> From: Graham Leggett [mailto:minfrin@sharp.fm]
> Sent: dinsdag 19 november 2013 18:44
> To: dev@httpd.apache.org
> Subject: Re: [Patch] non blocking writes in core
>=20
> On 18 Nov 2013, at 1:24 PM, "Pl=FCm, R=FCdiger, Vodafone Group"
> <ruediger.pluem@vodafone.com> wrote:
>=20
> > +        rv =3D send_brigade_nonblocking(net->client_socket, bb,
> > +                                      &(ctx->bytes_written), c);
> > +        if (APR_STATUS_IS_EAGAIN(rv)) {
> > +            setaside_remaining_output(f, ctx, bb, c);
> > +        }
> > +        else if (rv !=3D APR_EAGAIN) {
> >
> > What if rv is APR_SUCCESS?
>=20
> This is indeed broken, fixed.

This also breaks unsafe for platforms where there are multiple EAGAIN
values, like on Windows where APR_STATUS_IS_EAGAIN() returns true for =
quite
a few error codes.

	Bert