Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5787B103E5 for ; Mon, 21 Oct 2013 15:09:19 +0000 (UTC) Received: (qmail 90665 invoked by uid 500); 21 Oct 2013 15:09:16 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 90498 invoked by uid 500); 21 Oct 2013 15:09:10 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 90483 invoked by uid 99); 21 Oct 2013 15:09:08 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Oct 2013 15:09:08 +0000 X-ASF-Spam-Status: No, hits=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jorton@redhat.com designates 209.132.183.28 as permitted sender) Received: from [209.132.183.28] (HELO mx1.redhat.com) (209.132.183.28) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 21 Oct 2013 15:09:03 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r9LF8fe1029048 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Mon, 21 Oct 2013 11:08:41 -0400 Received: from iberis.manyfish.co.uk (vpn-58-253.rdu2.redhat.com [10.10.58.253]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id r9LF8eTh009199 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Mon, 21 Oct 2013 11:08:40 -0400 Received: from jorton by iberis.manyfish.co.uk with local (Exim 4.80.1) (envelope-from ) id 1VYH5z-0003Iw-Jx for dev@httpd.apache.org; Mon, 21 Oct 2013 16:08:39 +0100 Date: Mon, 21 Oct 2013 16:08:39 +0100 From: Joe Orton To: dev@httpd.apache.org Subject: Re: stop copying footers to r->headers_in? Message-ID: <20131021150839.GA12571@redhat.com> Mail-Followup-To: dev@httpd.apache.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Organization: Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham (USA), Mark Hegarty (Ireland), Matt Parson (USA), Charlie Peters (USA) X-Scanned-By: MIMEDefang 2.67 on 10.5.11.11 X-Virus-Checked: Checked by ClamAV on apache.org On Sat, Oct 19, 2013 at 10:13:21AM -0400, Eric Covener wrote: > now: > > 1) add r->footers_in and use it in 2.2 and up by default > 2) add a directive to copy them up to r->headers_in (for those broken > by the change) Bikeshed... r->trailers_in? +1 to all this anyway. I'd be tempted to (lazily) stop here to see whether any users actually care about trailers. It looks like a pain to thread this change through both versions of ap_get_mime_headers*().