httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Covener <cove...@gmail.com>
Subject Re: deflate_in_filter double ap_get_brigade() call
Date Sat, 26 Oct 2013 13:26:52 GMT
On Fri, Oct 25, 2013 at 10:38 AM, Yann Ylavic <ylavic.dev@gmail.com> wrote:
> Is it intended to call ap_get_brigade() a second time when the EOS is there
> the first time?
> The second call is likely to return APR_EOF which is quite different than
> EOS brigade...

It does seem fishy, probably copied from the earlier he blocks where
ap_get_brigade was not called at all before removing the filter to
step aside.

There does seem to be a zero-byte deflated response in the test
framework and it passes w/o the extra call.  W

-- 
Eric Covener
covener@gmail.com

Mime
View raw message