httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: [PATCH 55315] mod_proxy interpolation code broken by regression to APR-util 1.5.2
Date Wed, 16 Oct 2013 17:49:17 GMT
On Wed, Oct 16, 2013 at 8:49 AM, Jeff Trawick <trawick@gmail.com> wrote:

> On Wed, Oct 9, 2013 at 2:17 PM, Mike Rumph <mike.rumph@oracle.com> wrote:
>
>>  Okay, I've confirmed that the following configuration works for httpd
>> trunk and httpd 2.2.25:
>>
>>
>>      RewriteEngine On****
>>
>> ** **
>>
>>      RewriteCond %{HTTPS} =off****
>>
>>      RewriteRule . - [E=protocol:http]****
>>
>>      RewriteCond %{HTTPS} =on****
>>
>>      RewriteRule . - [E=protocol:https]****
>>
>> ** **
>>
>>      RewriteRule ^/my_app/(.*) %{ENV:protocol}://1.2.3.4/my_app/$1 [P]****
>>
>>      ProxyPassReverse /my_app/ http://1.2.3.4/my_app/****
>>
>>      ProxyPassReverse /my_app/ https://1.2.3.4/my_app/
>>
>> So I submit the attached patch to the doc for review.
>>
>> Thanks,
>>
>> Mike Rumph
>>
>> The patch looks reasonable to me, though I will change "is not permitted
> within the scheme" to "is not supported within the scheme" since there is
> no logic to disallow it (it simply doesn't work). Any concerns before I
> commit?
>

BTW, I moved the example to ProxyPass since that seemed to be the natural
place, and to the end of the doc for the directive so that unrelated text
didn't get trapped after the example.  This is now in trunk/2.4.x/2.2.x...

Thanks for the patch!


>
>
>> On 9/17/2013 9:32 AM, Jim Jagielski wrote:****
>>
>>   +1****
>>
>> On Sep 17, 2013, at 11:32 AM, Jeff Trawick <trawick@gmail.com><trawick@gmail.com>wrote:
>> ****
>>
>> not really a rewrite fan, but I think that's better than code****
>>
>> so IMO we should doc that interpolation isn't supported in the scheme, and instead
a solution like that should be used
>>
>>
>>
>
>
> --
> Born in Roswell... married an alien...
> http://emptyhammock.com/
>



-- 
Born in Roswell... married an alien...
http://emptyhammock.com/

Mime
View raw message