httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1533169 - /httpd/httpd/trunk/modules/proxy/proxy_util.c
Date Fri, 18 Oct 2013 11:27:06 GMT
On Fri, Oct 18, 2013 at 1:11 PM, Ruediger Pluem <rpluem@apache.org> wrote:

> jim@apache.org wrote:
> > +    if ((thelen < dlen-1) || (src[thelen] == '\0') {
>
> Can't this be reduced to just
>
> if (src[thelen] == '\0') {
>
> ?
>

Not if src and dlen are zero?
IMHO the underflow (in the original code) should really be handled
explicitly.


>
> Regards
>

Mime
View raw message