Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 6AEFC108DF for ; Sat, 14 Sep 2013 11:14:00 +0000 (UTC) Received: (qmail 92359 invoked by uid 500); 14 Sep 2013 11:13:56 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 92329 invoked by uid 500); 14 Sep 2013 11:13:54 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 92305 invoked by uid 99); 14 Sep 2013 11:13:51 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Sep 2013 11:13:51 +0000 X-ASF-Spam-Status: No, hits=0.0 required=5.0 tests= X-Spam-Check-By: apache.org Received-SPF: error (athena.apache.org: local policy) Received: from [194.242.35.176] (HELO node176.itex.at) (194.242.35.176) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 14 Sep 2013 11:13:45 +0000 Received: from localhost (localhost [127.0.0.1]) by node176.itex.at (Postfix) with ESMTP id DF3BB20AB6; Sat, 14 Sep 2013 13:13:03 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at node176.itex.at Received: from node176.itex.at ([127.0.0.1]) by localhost (node176.itex.at [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SzjYaETcAlVl; Sat, 14 Sep 2013 13:13:03 +0200 (CEST) Received: from [172.17.100.8] (ip-109-91-98-102.unitymediagroup.de [109.91.98.102]) (Authenticated sender: apache@gknw.net) by node176.itex.at (Postfix) with ESMTPSA id 9182F20559; Sat, 14 Sep 2013 13:13:03 +0200 (CEST) Message-ID: <523444B5.5030601@apache.org> Date: Sat, 14 Sep 2013 13:12:53 +0200 From: Guenter Knauf User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130801 Thunderbird/17.0.8 MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: svn commit: r1523207 - /httpd/httpd/trunk/modules/lua/lua_request.c References: <20130914105511.33A6D23889ED@eris.apache.org> <5234416B.7070203@cord.dk> In-Reply-To: <5234416B.7070203@cord.dk> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org On 14.09.2013 12:58, Daniel Gruno wrote: > On 09/14/2013 12:55 PM, fuankg@apache.org wrote: >> Author: fuankg >> Date: Sat Sep 14 10:55:10 2013 >> New Revision: 1523207 >> >> URL: http://svn.apache.org/r1523207 >> Log: >> Fixed ap_ntoh64 argument. >> >> Modified: >> httpd/httpd/trunk/modules/lua/lua_request.c >> >> Modified: httpd/httpd/trunk/modules/lua/lua_request.c >> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/lua/lua_re= quest.c?rev=3D1523207&r1=3D1523206&r2=3D1523207&view=3Ddiff >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >> --- httpd/httpd/trunk/modules/lua/lua_request.c (original) >> +++ httpd/httpd/trunk/modules/lua/lua_request.c Sat Sep 14 10:55:10 20= 13 >> @@ -2153,7 +2153,7 @@ static int lua_websocket_write(lua_State >> else { >> apr_uint64_t llen =3D len; >> ap_rputc(127, r); >> - llen =3D ap_ntoh64(&len); /* ntoh doubles as hton */ >> + llen =3D ap_ntoh64(&llen); /* ntoh doubles as hton */ >> ap_rwrite((char*) &llen, 8, r); >> } >> } >> >> > Well spotted, Sir! thanks for the fix. haha, not me - the compiler did! ### mwccnlm Compiler: # File: lua_request.c # ---------------------- # 2156: llen =3D ap_ntoh64(&len); /* ntoh doubles as hton= */ # Error: ^ # illegal implicit conversion from 'unsigned int *' to # 'const unsigned long long *' # Too many errors printed, aborting program That are sometimes the benefits of picky compilers ;-) G=C3=BCn.