httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Yann Ylavic <ylavic....@gmail.com>
Subject Re: svn commit: r1524161 - in /httpd/httpd/trunk: CHANGES docs/log-message-tags/next-number modules/http/http_filters.c server/protocol.c
Date Thu, 19 Sep 2013 16:30:08 GMT
Sorry for the disorder gmail made from my previous message, regarding the
changes, I re-post :

On Thu, Sep 19, 2013 at 6:08 PM, Yann Ylavic <ylavic.dev@gmail.com> wrote:

> On Thu, Sep 19, 2013 at 5:32 PM, Plüm, Rüdiger, Vodafone Group <
> ruediger.pluem@vodafone.com> wrote:
>
>> What did you change from the original patch?
>>
>
> I changed :
> - conn->keepalive = AP_CONN_CLOSE
> ; according to your comment,
> -
> APR_ENOTIMPL => APR_EGENERAL
>  
> in ap_http_filter
> ;
>  
> so that ap_map_http_request_error
>  
> returns 400 and not 501,
> - APLOG_WARNING => APLOG_INFO
> ; when "using read-until-close"
> ,
>
> - (strcasecmp(tenc, "chunked") != 0 && !ap_find_last_token(f->r->pool,
> tenc, "chunked"))
> 
>    => !(strcasecmp(tenc, "chunked") == 0 ||
> ap_find_last_token(f->r->pool, tenc, "chunked"));
>    this one shouldn"t harm and is more what the comment (draft) says
> 
> .
> 
> - if (...) { fall through } else if (f->r->proxyreq != PROXYREQ_RESPONSE)
> { return EGENERAL } else { fall through }
>   => if (...) { fall through } else if (f->r->proxyreq ==
> PROXYREQ_RESPONSE) { fall through }  else { return EGENERAL };
>   shouldn't harm either, just to end with the failure condition.
>

Mime
View raw message