httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Kalu┼ża <jkal...@redhat.com>
Subject [PATCH] Fix settings options with ProxyPassMatch
Date Mon, 16 Sep 2013 12:44:08 GMT
Hi,

I have found out that if you use ProxyPassMatch with regexp and "$1" 
(see PR 43513 and PR 54973), the right proxy_worker is not used and 
"reverse" proxy_worker is used instead. The result is situation where no 
options like "timeout" can be set in this case.

The real problem here is that proxy_worker is chosen according to its 
name which contains "$1" sequence in our case.

I have found out that there is already patch fixing ProxyPassMatch 
behaviour with "$1" in PR 43513. I have rebased the patch for trunk and 
changed its style a bit.

The patch strips everything after "$", so it for example changes the 
name of proxy_worker from "http://127.0.0.1/cgi-bin/$1" to 
"http://127.0.0.1/cgi-bin/". Later when request arrives, proper 
proxy_worker is chosen. Without this change, proxy_worker's name with 
"$1" would be compared against real request URL, but real request URL 
does not contain this "$1" sequence and therefore this correct 
proxy_worker wouldn't be chosen.

Do you see any problems with this patch?

Regards,
Jan Kaluza

Mime
View raw message