httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Guenter Knauf <fua...@apache.org>
Subject Re: svn commit: r1523207 - /httpd/httpd/trunk/modules/lua/lua_request.c
Date Sat, 14 Sep 2013 11:12:53 GMT
On 14.09.2013 12:58, Daniel Gruno wrote:
> On 09/14/2013 12:55 PM, fuankg@apache.org wrote:
>> Author: fuankg
>> Date: Sat Sep 14 10:55:10 2013
>> New Revision: 1523207
>>
>> URL: http://svn.apache.org/r1523207
>> Log:
>> Fixed ap_ntoh64 argument.
>>
>> Modified:
>>      httpd/httpd/trunk/modules/lua/lua_request.c
>>
>> Modified: httpd/httpd/trunk/modules/lua/lua_request.c
>> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/lua/lua_request.c?rev=1523207&r1=1523206&r2=1523207&view=diff
>> ==============================================================================
>> --- httpd/httpd/trunk/modules/lua/lua_request.c (original)
>> +++ httpd/httpd/trunk/modules/lua/lua_request.c Sat Sep 14 10:55:10 2013
>> @@ -2153,7 +2153,7 @@ static int lua_websocket_write(lua_State
>>           else {
>>               apr_uint64_t llen = len;
>>               ap_rputc(127, r);
>> -            llen = ap_ntoh64(&len); /* ntoh doubles as hton */
>> +            llen = ap_ntoh64(&llen); /* ntoh doubles as hton */
>>               ap_rwrite((char*) &llen, 8, r);
>>           }
>>       }
>>
>>
> Well spotted, Sir! thanks for the fix.
haha, not me - the compiler did!

### mwccnlm Compiler:
#    File: lua_request.c
# ----------------------
#    2156:              llen = ap_ntoh64(&len); /* ntoh doubles as hton */
#   Error:                                   ^
#   illegal implicit conversion from 'unsigned int *' to
#   'const unsigned long long *'
#   Too many errors printed, aborting program


That are sometimes the benefits of picky compilers ;-)

Gün.


Mime
View raw message