httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Paul Querna <p...@querna.org>
Subject Re: [PATCH] systemd socket activation
Date Tue, 06 Aug 2013 16:53:52 GMT
Committed to trunk in r1511033.

On Wed, Jul 24, 2013 at 12:00 AM, Jan Kalu┼ża <jkaluza@redhat.com> wrote:
> On 07/21/2013 11:14 PM, Paul Querna wrote:
>>
>> Hiya Y'all, long time no patches :-)
>>
>> Attached is a patch that would let httpd use systemd's socket
>> activation feature:
>>    <http://0pointer.de/blog/projects/socket-activation.html>
>>
>> Also online here:
>>
>> <https://github.com/pquerna/httpd/compare/trunk...systemd_socket_activation>
>
>
> Hi,
>
> I have tried the patch on F18 with httpd-2.4.6 and it works as expected. I
> really like it :).
>
> Regards,
> Jan Kaluza
>
>
>> It isn't particularly pretty;  Mostly it is working within how
>> listener code already works.  You can test it yourself very easily
>> using something like:
>>
>>     /usr/lib/systemd/systemd-activate -l 0.0.0.0:8080 -l 9080
>> /usr/local/httpd-dev/bin/httpd -DFOREGROUND
>>
>> You'll note it works with multiple listeners.  I've been testing it on
>> Fedora 19, and it seems fine there.
>>
>> Now, the patch is not part of mod_systemd.  This is mostly because the
>> listener.c code isn't exactly friendly to a non-core module messing
>> around with the listeners.  I'd definitely be +1 to a larger
>> refactoring of listen.c, but not sure I have the time / energy to head
>> that up.
>>
>> If there aren't any objections I'll commit it into trunk in a few days,
>>
>> Thanks,
>>
>> Paul
>>
>

Mime
View raw message