httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: [PATCH] fix timeout in mod_ssl's trace2 log output
Date Mon, 05 Aug 2013 13:01:02 GMT
On Mon, Aug 5, 2013 at 7:19 AM, Faidon Liambotis <paravoid@debian.org>wrote:

> "timeout" is nowadays a duration, not an absolute value. Fix the trace2
> output to print it as such, instead of subtracting time(NULL) and
> resulting in lines such as:
>
> [Mon Aug 05 03:51:07.369625 2013] [ssl:trace2] [pid 7916:tid
> 140003006699264] ssl_engine_kernel.c(1698): Inter-Process Session Cache:
> request=SET status=OK
> id=e53934c8b21017256ebe00327be265ccbb82bbaaef52adb900a884a07ad32eac
> timeout=-1375674367s (session caching)
>
> --- modules/ssl/ssl_engine_kernel.c     (revision 1510425)
> +++ modules/ssl/ssl_engine_kernel.c     (working copy)
> @@ -1687,7 +1687,7 @@
>
>      if (timeout) {
>          apr_snprintf(timeout_str, sizeof(timeout_str),
> -                     "timeout=%lds ", (timeout - time(NULL)));
> +                     "timeout=%lds ", timeout);
>      }
>
>      ap_log_error(APLOG_MARK, APLOG_TRACE2, 0, s,
>

Someone else committed this to trunk yesterday (
http://svn.apache.org/viewvc?view=revision&revision=r1510098), and it now
has 2 of 3 necessary votes to appear in the next 2.4.x release.


-- 
Born in Roswell... married an alien...
http://emptyhammock.com/

Mime
View raw message