Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (nike.apache.org: domain of chris_se@gmx.net designates
 212.227.17.20 as permitted sender)
Message-ID: <51D1DA73.8020804@gmx.net>
Date: Mon, 01 Jul 2013 21:37:23 +0200
From: Christian Seiler <chris_se@gmx.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64;
 rv:10.0.7) Gecko/20120916 Thunderbird/10.0.7
MIME-Version: 1.0
To: dev@httpd.apache.org
Subject: Re: stop copying r->content_type to r->handler?
References: 
 <CALK=YjPtR9s2tAVRYUA_QYbVT72U3iQ9Hvq6_YyLvFkiVgyZ4A@mail.gmail.com>
 <9644a4ff602b9ef21a876be95a2116d1@iwakd.de>
 <CALK=YjNYrx64pAeyFBuJK8wVc1fjRaCUdpgpEsh-NOv0COgRcw@mail.gmail.com>
 <CALK=YjMr5uMJeM8NxwmpccxE9AcOy0KChPJ-MnX9T2Ru_gKSig@mail.gmail.com>
In-Reply-To: 
 <CALK=YjMr5uMJeM8NxwmpccxE9AcOy0KChPJ-MnX9T2Ru_gKSig@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

Hi,

> It looks like mod_actions does not recognize r->handler set to "" --
> when r->handler is NULL, he will look directly to r->content_type, so
> that may be a potential way to still handle content-type based
> "dispatch" without having the content-type sit in r->handler.

What you suggest would, as far as I can see, make my configuration still
work as expected but allow you to remove the copy of r->content_type, so
I don't have any objections to that. From a coding perspective, this
seems cleaner to me.

By the way, I just cross-checked against the current mod_php [1], and
they check against r->handler, so your change would probably break
current mod_php regardless of mod_actions. On the other hand, a) my
guess is that this change will not make it into 2.4 or lower anyway, so
there should be plenty of time to write a release note about that and b)
as far as I understand it (I may be wrong about this) mod_php is
discouraged in favor of FastCGI anyway nowadays.

The interesting thing would be to see how many other modules also check
r->handler for content_type.

-- Christian

[1]
http://git.php.net/?p=php-src.git;a=blob;f=sapi/apache2handler/sapi_apache2.c;h=b7f95e0c1272996b48cee904d9fe98c062c6c413;hb=refs/heads/master