httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Kalu┼ża <jkal...@redhat.com>
Subject Re: [PATCH] mod_unique_id: use ap_random_insecure_bytes() to get unique ID
Date Thu, 11 Jul 2013 06:29:36 GMT
On 07/10/2013 06:24 PM, Joe Orton wrote:
> On Tue, Jul 09, 2013 at 11:02:18PM +0200, Stefan Fritsch wrote:
>> On Tuesday 09 July 2013, Joe Orton wrote:
>>> On Tue, Jul 09, 2013 at 10:00:19AM +0200, Jan Kaluza wrote:
>>>> I agree 20 bytes could be too much. I have changed my patch to
>>>> have only 10 bytes long root. I will check the Daniel's ideas
>>>> mentioned in another mail in this thread and try to implement
>>>> it, but if we are going to do it my way, I think this patch
>>>> should be OK.
>>>
>>> +1 here, this looks good to me.
>>
>> +1
>
> Thanks for the review Stefan & thanks for the patch Jan!
>
> => http://svn.apache.org/viewvc?view=revision&revision=1501827
>
> This patch actually removes the noticeable delay when running the test
> suite, while A::T waits for httpd to start serving requests!  I had no
> idea that was caused by mod_unique_id.  Very cool :)
>
> Regards, Joe
>

Thank you all for reviewing and accepting the patch.

Regards,
Jan Kaluza


Mime
View raw message