httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Orton <jor...@redhat.com>
Subject Re: [PATCH] systemd socket activation
Date Tue, 23 Jul 2013 10:11:28 GMT
On Sun, Jul 21, 2013 at 02:14:35PM -0700, Paul Querna wrote:
> Hiya Y'all, long time no patches :-)
> 
> Attached is a patch that would let httpd use systemd's socket
> activation feature:
>   <http://0pointer.de/blog/projects/socket-activation.html>
> 
> Also online here:
>   <https://github.com/pquerna/httpd/compare/trunk...systemd_socket_activation>
> 

Hi Paul - this is neat!  A surprisingly simple patch, I like it a lot, 
+1 for trunk.

I guess we still need to set O_NONBLOCK on inherited sockets in the same 
way that open_listeners() does?  But otherwise leaving socket options to 
the systemd .socket seems reasonable, I guess.  Having the "https == 
443" heuristic is annoying but no obvious way round that.

Regards, Joe

Mime
View raw message