Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: domain of covener@gmail.com designates
 209.85.212.41 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <51811A0C.5040604@yuhu.biz>
References: <5180C2EE.4030407@yuhu.biz>
	<CALK=YjNiGFFchkuXYNMMWN+cSkcpxTs1Uuqisg8LaWShX1aj4A@mail.gmail.com>
	<51811A0C.5040604@yuhu.biz>
Date: Wed, 1 May 2013 10:20:28 -0400
Message-ID: 
 <CALK=YjMtL4pYQmwUk7S3jzh4xxQBqg_Fyx=YpSkma8yu6_SzQw@mail.gmail.com>
Subject: Re: input filter problem
From: Eric Covener <covener@gmail.com>
To: Marian Marinov <mm@yuhu.biz>
Cc: dev@httpd.apache.org
Content-Type: text/plain; charset=ISO-8859-1

> I understand that, however I don't understand how to make my module run the
> input_filters without consuming the request.
>
> What I mean is that if I add the following, it will consume the actual
> request.
>
>         rv = ap_get_brigade(r->input_filters, bb, AP_MODE_READBYTES,
> APR_BLOCK_READ, HUGE_STRING_LEN);
>
>         if (rv != APR_SUCCESS) {
>             ap_log_rerror(APLOG_MARK, APLOG_ERR, rv, r, "Error reading
> request entity data");
>             return HTTP_INTERNAL_SERVER_ERROR;
>         }
>
>         for (bucket = APR_BRIGADE_FIRST(bb); bucket !=
> APR_BRIGADE_SENTINEL(bb); bucket = APR_BUCKET_NEXT(bucket)) {
>             const char *data;
>             apr_size_t len;
>
> Do you have any suggestions?


I didn't realize your handler returned DECLINED.  Either it will run
before the post body is read, or it will not run at all.  You can't
really write anything that runs before the real handler that also
notices something your input filter will change.  There is a module in
2.4 that allows the request body to be buffered, but I don't know much
about it. http://httpd.apache.org/docs/trunk/mod/mod_buffer.html

I guess it mostly depends on what you expect to do with the
information outside of the filter.

--
Eric Covener
covener@gmail.com