httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gregg Smith <...@gknw.net>
Subject Re: mod_ssl NPN API rejig (was Re: Intent to revert commit r1332643)
Date Wed, 29 May 2013 21:07:05 GMT
On 5/29/2013 10:52 AM, Guenter Knauf wrote:
> Hi Joe,
> On 29.05.2013 18:06, Joe Orton wrote:
>> On Wed, May 29, 2013 at 11:37:14AM -0400, Matthew Steele wrote:
>>> Oops, yes, RUN_ALL semantics are desired; the misleading API 
>>> description is
>>> my fault, sorry.  (I confess I never really understood why RUN_ALL 
>>> hooks
>>> accept both OK and DECLINED values, but then don't actually treat 
>>> them any
>>> differently.)  So probably we should update the doc comments.  I'd 
>>> be happy
>>> to draft new versions for those if that would be helpful, or not, as 
>>> you
>>> prefer.
>>
>> OK vs DECLINED has always confused me too ;)
>>
>> How does this look?  I've specified the behaviour for OK and DONE as
>> return codes for both the callbacks; since the caller doesn't pay
>> attention to errors I've left behaviour undefined for any other values.
>>
>> (Really attached this time)
> thanks for looking into it!
> I will test tomorrow; need a rest just now since was the whole day 
> busy at customers; but perhaps Gregg beats me soon ...

Compiles fine now. Didn't do much testing other than access a simple 
page via https

Gregg


Mime
View raw message