httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r1484832 - in /httpd/httpd/trunk: CHANGES modules/filters/mod_deflate.c
Date Tue, 21 May 2013 19:12:22 GMT


minfrin@apache.org wrote:
> Author: minfrin
> Date: Tue May 21 15:10:46 2013
> New Revision: 1484832
> 
> URL: http://svn.apache.org/r1484832
> Log:
> mod_deflate: Remove assumptions as to when an EOS bucket might arrive.
> Gracefully step aside if the body size is zero.
> 
> Modified:
>     httpd/httpd/trunk/CHANGES
>     httpd/httpd/trunk/modules/filters/mod_deflate.c
> 

> Modified: httpd/httpd/trunk/modules/filters/mod_deflate.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/filters/mod_deflate.c?rev=1484832&r1=1484831&r2=1484832&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/filters/mod_deflate.c (original)
> +++ httpd/httpd/trunk/modules/filters/mod_deflate.c Tue May 21 15:10:46 2013

> @@ -1120,8 +1142,7 @@ static apr_status_t deflate_in_filter(ap
>  
>                  inflateEnd(&ctx->stream);
>  
> -                eos = apr_bucket_eos_create(f->c->bucket_alloc);
> -                APR_BRIGADE_INSERT_TAIL(ctx->proc_bb, eos);
> +                ctx->done = 1;
>                  break;

Don't we need to remove the break here as well to process a possible EOS bucket that is still
in the brigade?

>              }
>  

Regards

RĂ¼diger

Mime
View raw message