httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ruediger Pluem <rpl...@apache.org>
Subject Re: svn commit: r1480058 - in /httpd/httpd/trunk: CHANGES modules/proxy/mod_proxy_ftp.c modules/proxy/mod_proxy_http.c modules/proxy/proxy_util.c
Date Wed, 08 May 2013 07:47:16 GMT


minfrin@apache.org wrote:
> Author: minfrin
> Date: Tue May  7 20:27:37 2013
> New Revision: 1480058
> 
> URL: http://svn.apache.org/r1480058
> Log:
> mod_proxy: Ensure network errors detected by the proxy are returned as
> 504 Gateway Timout as opposed to 502 Bad Gateway, in order to be
> compliant with RFC2616 14.9.4 Cache Revalidation and Reload Controls.
> 
> Modified:
>     httpd/httpd/trunk/CHANGES
>     httpd/httpd/trunk/modules/proxy/mod_proxy_ftp.c
>     httpd/httpd/trunk/modules/proxy/mod_proxy_http.c
>     httpd/httpd/trunk/modules/proxy/proxy_util.c
> 
>

I don't agree with this. The case you mention is only true if the client sends Cache-Control:
must-revalidate.
If this is not the case IMHO 10.5.3 and 10.5.5 apply.
And only a cache is required to respond with 504 in this case, not a gateway or a proxy. So
the cache should
change a 502 to a 504 in case the revalidation fails. Imagine the case where you have other
backend modules
as our proxy modules.
So while changing the response to 504 for failed DNS lookups is always correct it is not for
other failures.
10.5.3: The server, while acting as a gateway or proxy, received an invalid response from
the upstream server it
accessed in attempting to fulfill the request.

Regards

RĂ¼diger

Mime
View raw message