Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 45B04F9E5 for ; Sun, 31 Mar 2013 20:51:09 +0000 (UTC) Received: (qmail 96872 invoked by uid 500); 31 Mar 2013 20:51:08 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 96632 invoked by uid 500); 31 Mar 2013 20:51:07 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 96623 invoked by uid 99); 31 Mar 2013 20:51:07 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 31 Mar 2013 20:51:07 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_NONE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: local policy) Received: from [80.12.242.133] (HELO smtp.smtpout.orange.fr) (80.12.242.133) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 31 Mar 2013 20:50:58 +0000 Received: from [127.0.0.1] ([90.63.89.160]) by mwinf5d46 with ME id JLqd1l00N3Taeki03LqenB; Sun, 31 Mar 2013 22:50:38 +0200 Message-ID: <5158A19D.5090400@wanadoo.fr> Date: Sun, 31 Mar 2013 22:50:37 +0200 From: Marion & Christophe JAILLET User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/20130307 Thunderbird/17.0.4 MIME-Version: 1.0 To: dev@httpd.apache.org Subject: Re: svn commit: r1463045 - /httpd/httpd/trunk/modules/aaa/mod_auth_digest.c References: <20130331201348.80F5A2388847@eris.apache.org> In-Reply-To: <20130331201348.80F5A2388847@eris.apache.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Antivirus: avast! (VPS 130331-0, 31/03/2013), Outbound message X-Antivirus-Status: Clean X-Virus-Checked: Checked by ClamAV on apache.org Hi, they are 3 similar constructions in server/log.c CJ Le 31/03/2013 22:13, sf@apache.org a écrit : > Author: sf > Date: Sun Mar 31 20:13:48 2013 > New Revision: 1463045 > > URL: http://svn.apache.org/r1463045 > Log: > ap_log_error already logs the error string, no need to log it twice > > Modified: > httpd/httpd/trunk/modules/aaa/mod_auth_digest.c > > Modified: httpd/httpd/trunk/modules/aaa/mod_auth_digest.c > URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/aaa/mod_auth_digest.c?rev=1463045&r1=1463044&r2=1463045&view=diff > ============================================================================== > --- httpd/httpd/trunk/modules/aaa/mod_auth_digest.c (original) > +++ httpd/httpd/trunk/modules/aaa/mod_auth_digest.c Sun Mar 31 20:13:48 2013 > @@ -240,10 +240,8 @@ static apr_status_t initialize_secret(se > #endif > > if (status != APR_SUCCESS) { > - char buf[120]; > ap_log_error(APLOG_MARK, APLOG_CRIT, status, s, APLOGNO(01758) > - "error generating secret: %s", > - apr_strerror(status, buf, sizeof(buf))); > + "error generating secret"); > return status; > } > > > >