Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (nike.apache.org: domain of covener@gmail.com designates
 209.85.220.177 as permitted sender)
MIME-Version: 1.0
In-Reply-To: <51200D75.5060605@kippdata.de>
References: <20130212105442.F313D23889ED@eris.apache.org>
	<CALK=YjP_1-X6HuqiUDY8hdSzP+=SCeHvgP_LxLxeWAU4i+0UNQ@mail.gmail.com>
	<51200D75.5060605@kippdata.de>
Date: Sat, 16 Feb 2013 18:05:01 -0500
Message-ID: 
 <CALK=YjN=95k6O-Na+3T1JLHJrbfaz6SwCdQcAPm=Pm6xA0tm1g@mail.gmail.com>
Subject: Re: svn commit: r1445100 - in /httpd/httpd/branches/2.2.x: ./ CHANGES
 STATUS server/mpm_common.c
From: Eric Covener <covener@gmail.com>
To: dev@httpd.apache.org
Content-Type: text/plain; charset=ISO-8859-1

On Sat, Feb 16, 2013 at 5:51 PM, Rainer Jung <rainer.jung@kippdata.de> wrote:
> On 16.02.2013 18:17, Eric Covener wrote:
>> On Tue, Feb 12, 2013 at 5:54 AM,  <rjung@apache.org> wrote:
>>> +    if (lp->protocol && strcasecmp(lp->protocol, "https") == 0) {
>>
>> Should this be ap_listeners? There is no local "lp" in my  2.2.x and
>> currently does not build (but I also just recently did a migration on
>> my system and somethings are flaky)
>
> You are totally right. I did build but did not notice, that the whole
> block is not being compiled when using the worker MPM, which I did.

I think the same MPM difference got me between original review and now
-- thanks for that hint.