httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Timothy Wood <...@omnigroup.com>
Subject Location header for dav_created not URI encoded
Date Tue, 26 Feb 2013 03:52:11 GMT

Again, I'm not sure this is the right approach, but returning a non-encoded URI certainly
isn't. In particular, I wonder if the optimization of using unparsed_uri is good or whether
the r->uri should be escaped.

Again, diff is vs our local copy of 2.4.3.

-tim


Index: trunk/Apache/httpd/modules/dav/main/mod_dav.c
===================================================================
--- trunk/Apache/httpd/modules/dav/main/mod_dav.c	(revision 180429)
+++ trunk/Apache/httpd/modules/dav/main/mod_dav.c	(revision 180431)
@@ -611,7 +611,9 @@
     const char *body;
 
     if (locn == NULL) {
-        locn = r->uri;
+        locn = r->unparsed_uri;
+    } else {
+        locn = ap_escape_uri(r->pool, locn);
     }
 
     /* did the target resource already exist? */



Mime
View raw message