Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (nike.apache.org: local policy)
Message-ID: <50C8FAA6.5090202@wanadoo.fr>
Date: Wed, 12 Dec 2012 22:44:06 +0100
From: Marion & Christophe JAILLET <christophe.jaillet@wanadoo.fr>
User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64;
 rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: dev@httpd.apache.org
CC: humbedooh@apache.org, cvs@httpd.apache.org
Subject: Re: svn commit: r1420377 - in /httpd/httpd/trunk:
 docs/manual/mod/mod_lua.xml
 modules/lua/lua_apr.c modules/lua/lua_apr.h modules/lua/mod_lua.c
References: <20121211200839.959322388962@eris.apache.org>
In-Reply-To: <20121211200839.959322388962@eris.apache.org>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit

Here are a few things triggered by cppcheck.


Le 11/12/2012 21:08, humbedooh@apache.org a écrit :
> Author: humbedooh
> Date: Tue Dec 11 20:08:24 2012
> New Revision: 1420377
>
> URL: http://svn.apache.org/viewvc?rev=1420377&view=rev
> Log:
> mod_lua: Add a lot of core httpd/apr functionality to mod_lua
> (such as regex matching, expr evaluation, changing/fetching server configuration/info - see docs for a complete list).
> This also includes a bunch of automatically scraped functions, which may or may not be super useful.
> Comments appreciated as always, especially on the more hacky bits.
>
>
> Modified: httpd/httpd/trunk/modules/lua/lua_apr.c
> URL: http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/lua/lua_apr.c?rev=1420377&r1=1420376&r2=1420377&view=diff
> ==============================================================================
> --- httpd/httpd/trunk/modules/lua/lua_apr.c (original)
> +++ httpd/httpd/trunk/modules/lua/lua_apr.c Tue Dec 11 20:08:24 2012

I've put the parsed file on:
     http://people.apache.org/~jailletc36/lua_apr.html
Check it from there. Things noticed by cppcheck are red-marked.

Except the 'The scope of the variable '...' can be reduced' that can be 
ignored, all the other remarks are relevant.

Especially:
      a useless apr_pcalloc (line 249)
      a out of bound access (line 321) --> I don't know if Rsha1 should 
be [20] or if the loop should be limited to < 16
                                       this seems to be a cut and paste 
error from lua_apr_md5
      a uninitialized variable (line 430)


CJ