Return-Path: X-Original-To: apmail-httpd-dev-archive@www.apache.org Delivered-To: apmail-httpd-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C5C66D5A6 for ; Tue, 18 Dec 2012 15:55:02 +0000 (UTC) Received: (qmail 50633 invoked by uid 500); 18 Dec 2012 15:55:01 -0000 Delivered-To: apmail-httpd-dev-archive@httpd.apache.org Received: (qmail 49984 invoked by uid 500); 18 Dec 2012 15:55:01 -0000 Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm Precedence: bulk Reply-To: dev@httpd.apache.org list-help: list-unsubscribe: List-Post: List-Id: Delivered-To: mailing list dev@httpd.apache.org Received: (qmail 49818 invoked by uid 99); 18 Dec 2012 15:55:00 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Dec 2012 15:55:00 +0000 X-ASF-Spam-Status: No, hits=-5.0 required=5.0 tests=RCVD_IN_DNSWL_HI,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of jorton@redhat.com designates 209.132.183.28 as permitted sender) Received: from [209.132.183.28] (HELO mx1.redhat.com) (209.132.183.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 18 Dec 2012 15:54:53 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id qBIFsWMv023011 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 18 Dec 2012 10:54:32 -0500 Received: from iberis.manyfish.co.uk (vpn-8-208.rdu.redhat.com [10.11.8.208]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id qBIFsVMI005897 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO) for ; Tue, 18 Dec 2012 10:54:32 -0500 Received: from jorton by iberis.manyfish.co.uk with local (Exim 4.76) (envelope-from ) id 1TkzV0-0004ra-RQ for dev@httpd.apache.org; Tue, 18 Dec 2012 15:54:30 +0000 Date: Tue, 18 Dec 2012 15:54:30 +0000 From: Joe Orton To: dev@httpd.apache.org Subject: Re: svn commit: r1423353 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/proxy/mod_proxy_ftp.c Message-ID: <20121218155430.GA18567@redhat.com> Mail-Followup-To: dev@httpd.apache.org References: <20121218090105.0EA6223889B8@eris.apache.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Organization: Registered in England and Wales under Company Registration No. 03798903 Directors: Michael Cunningham (USA), Mark Hegarty (Ireland), Matt Parson (USA), Charlie Peters (USA) X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Virus-Checked: Checked by ClamAV on apache.org On Tue, Dec 18, 2012 at 08:29:21AM -0500, Jeff Trawick wrote: > My understanding is that we don't maintain messages numbers for TRACE > messages, so the APLOGNO() could have been simply deleted. > > (I see several mod_lua messages that don't follow this pattern.) Ah, sorry, I didn't realise that. ISTR the empty macro broke the build on some platform from last time I screwed that up, so we need to fix it either way? Regards, Joe