Mailing-List: contact dev-help@httpd.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@httpd.apache.org
Received-SPF: pass (athena.apache.org: local policy)
From: Stefan Fritsch <sf@sfritsch.de>
To: dev@httpd.apache.org
Subject: Re: svn commit: r1419755 -
 /httpd/httpd/trunk/modules/http/http_filters.c
Date: Mon, 10 Dec 2012 23:15:26 +0100
User-Agent: KMail/1.13.7 (Linux/3.2.0-4-amd64; KDE/4.8.4; x86_64; ; )
References: <20121210205325.4364D238897F@eris.apache.org>
 <50C64E88.1090400@wanadoo.fr>
In-Reply-To: <50C64E88.1090400@wanadoo.fr>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="utf-8"
Content-Transfer-Encoding: 7bit
Message-Id: <201212102315.26567.sf@sfritsch.de>

On Monday 10 December 2012, Marion & Christophe JAILLET wrote:
> Just above this, there is the following comment :
>          /*
>           * Date and Server are less interesting, use TRACE5 for
> them while * using TRACE4 for the other headers.
>           */
> However, I don't see where the other headers are logged.

It's done in send_all_header_fields() which sends everything except 
"Date" and "Server". The comment is here because the trace4 for the ", 
headers:" string does not match the trace5 of the Server+Date header.

> You can find a little above:
>          ap_log_rerror(APLOG_MARK, APLOG_TRACE3, 0, r,
>                        "Response sent with status %d%s",
>                        r->status,
>                        APLOGrtrace4(r) ? ", headers:" : "");
> but, IMO, it does not log the headers, it only prints "headers: ".

> Apparently, it has been that way, since the beginning in
> 
http://svn.apache.org/viewvc?view=revision&sortby=date&revision=963057
>
> Should something be added here to match the comment, or remove the
> comment ?

Neither. But maybe add a comment that points to 
send_all_header_fields()?