httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jeff Trawick <traw...@gmail.com>
Subject Re: svn commit: r1423353 - in /httpd/httpd/trunk: docs/log-message-tags/next-number modules/proxy/mod_proxy_ftp.c
Date Tue, 18 Dec 2012 13:29:21 GMT
On Tue, Dec 18, 2012 at 4:01 AM, <jorton@apache.org> wrote:

> Author: jorton
> Date: Tue Dec 18 09:01:02 2012
> New Revision: 1423353
>
> URL: http://svn.apache.org/viewvc?rev=1423353&view=rev
> Log:
> * modules/proxy/mod_proxy_ftp.c: Fill in APLOGNO.
>
> Modified:
>     httpd/httpd/trunk/docs/log-message-tags/next-number
>     httpd/httpd/trunk/modules/proxy/mod_proxy_ftp.c
>
> Modified: httpd/httpd/trunk/docs/log-message-tags/next-number
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/docs/log-message-tags/next-number?rev=1423353&r1=1423352&r2=1423353&view=diff
>
> ==============================================================================
> --- httpd/httpd/trunk/docs/log-message-tags/next-number (original)
> +++ httpd/httpd/trunk/docs/log-message-tags/next-number Tue Dec 18
> 09:01:02 2012
> @@ -1 +1 @@
> -2410
> +2411
>
> Modified: httpd/httpd/trunk/modules/proxy/mod_proxy_ftp.c
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/proxy/mod_proxy_ftp.c?rev=1423353&r1=1423352&r2=1423353&view=diff
>
> ==============================================================================
> --- httpd/httpd/trunk/modules/proxy/mod_proxy_ftp.c (original)
> +++ httpd/httpd/trunk/modules/proxy/mod_proxy_ftp.c Tue Dec 18 09:01:02
> 2012
> @@ -1465,7 +1465,7 @@ static int proxy_ftp_handler(request_rec
>
>   "EPSV attempt to connect to %pI failed - firewall/NAT?", &epsv_addr));
>                  }
>                  else {
> -                    ap_log_rerror(APLOG_MARK, APLOG_TRACE1, 0, r,
> APLOGNO()
> +                    ap_log_rerror(APLOG_MARK, APLOG_TRACE1, 0, r,
> APLOGNO(02410)
>                                    "connected data socket to %pI",
> &epsv_addr);
>

My understanding is that we don't maintain messages numbers for TRACE
messages, so the APLOGNO() could have been simply deleted.

(I see several mod_lua messages that don't follow this pattern.)



>                      connect = 1;
>                  }
>
>
>


-- 
Born in Roswell... married an alien...
http://emptyhammock.com/

Mime
View raw message