httpd-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gregg Smith <...@gknw.net>
Subject Re: svn commit: r1420377 - in /httpd/httpd/trunk: docs/manual/mod/mod_lua.xml modules/lua/lua_apr.c modules/lua/lua_apr.h modules/lua/mod_lua.c
Date Fri, 14 Dec 2012 20:34:56 GMT
On 12/14/2012 2:17 AM, Daniel Gruno wrote:
> On 12/14/2012 10:48 AM, Guenter Knauf wrote:
>> Am 12.12.2012 22:44, schrieb Marion&  Christophe JAILLET:
>>> Here are a few things triggered by cppcheck.
>>>
>>>
>>> Le 11/12/2012 21:08, humbedooh@apache.org a écrit :
>>>> Author: humbedooh
>>>> Date: Tue Dec 11 20:08:24 2012
>>>> New Revision: 1420377
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1420377&view=rev
>>>> Log:
>>>> mod_lua: Add a lot of core httpd/apr functionality to mod_lua
>>>> (such as regex matching, expr evaluation, changing/fetching server
>>>> configuration/info - see docs for a complete list).
>>>> This also includes a bunch of automatically scraped functions, which
>>>> may or may not be super useful.
>>>> Comments appreciated as always, especially on the more hacky bits.
>>>>
>>>>
>>>> Modified: httpd/httpd/trunk/modules/lua/lua_apr.c
>>>> URL:
>>>> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/lua/lua_apr.c?rev=1420377&r1=1420376&r2=1420377&view=diff
>>>>
>>>>
>>>> ==============================================================================
>>>>
>>>>
>>>> --- httpd/httpd/trunk/modules/lua/lua_apr.c (original)
>>>> +++ httpd/httpd/trunk/modules/lua/lua_apr.c Tue Dec 11 20:08:24 2012
> Thanks for the heads up, guys!
> I didn't receive Christophe's email, which is why I didn't put these
> fixes up till now. I will try to use that cppcheck program in the
> future, it seems very nice, and catches some things that my regular
> compiler warning settings don't. So thanks for that as well :)
Evidently an unused variable.
.\lua_request.c(227) : warning C4101: 'z' : unreferenced local variable

On the Windows side of things;

lua_apr.c in use all over are uint32_t and we do not have uint32_t 
available. apr_uint32_t works well.

Then there is;
.\lua_apr.c(567) : error C2440: 'function' : cannot convert from 
'apr_os_thread_t' to 'lua_Number'

In scoreboard.h, tms is declared if HAVE_TIMES is defined. I assume that 
is sys/times.h which we do not seem to have.
It seems there may be an APR alternative to this that I saw in 
modules\dav\fs\repos.c which may or may not be usable here or Windows 
will just have to go without these if possible.

.\lua_apr.c(575) : error C2039: 'times' : is not a member of 'worker_score'
         c:\build4\httpd-head-r1421953\include\scoreboard.h(90) : see 
declaration of 'worker_score'

.\lua_apr.c(579) : error C2039: 'times' : is not a member of 'worker_score'
         c:\build4\httpd-head-r1421953\include\scoreboard.h(90) : see 
declaration of 'worker_score'

Regards,
Gregg



Mime
View raw message